Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1676573002: Add name/offset constructors for default parameter elements. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add name/offset constructors for default parameter elements. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d4d840e598446f61b20d371c81265ecf98e42254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -14 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 4 chunks +25 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-05 19:18:29 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-05 19:39:24 UTC) #2
scheglov
4 years, 10 months ago (2016-02-05 20:40:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d4d840e598446f61b20d371c81265ecf98e42254 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698