Source/core/dom/Document.cpp - Issue 167653002: Make importNode work when the XML document contains a CDATA section

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 167653002: Make importNode work when the XML document contains a CDATA section (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add testcase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index 452ee77862f85014bc01b7558ce192e858fbfef5..ea3cbc390a1862d438aa91858820db7295ae339d 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -896,7 +896,7 @@ PassRefPtr<Node> Document::importNode(Node* importedNode, bool deep, ExceptionSt

case TEXT_NODE:

return createTextNode(importedNode->nodeValue());

case CDATA_SECTION_NODE:

- return createCDATASection(importedNode->nodeValue(), exceptionState);

+ return importedNode->cloneNode(deep);

adamk 2014/02/19 17:04:59 cloneNode alone can't be used to implement importN

case PROCESSING_INSTRUCTION_NODE:

return createProcessingInstruction(importedNode->nodeName(), importedNode->nodeValue(), exceptionState);

case COMMENT_NODE:

« no previous file with comments | « LayoutTests/fast/dom/importNode-cdata-expected.txt ('k') | no next file » | no next file with comments »