third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html - Issue 1676513003: Move background/webkit-mask shorthands into CSSPropertyParser

Unified Diff: third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html

Issue 1676513003: Move background/webkit-mask shorthands into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix background-size logic Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/backgrounds/background-clip-per-layer.html ('K') | « third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt » ('j') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html

diff --git a/third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html b/third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html

index 25adc59617330181d790892a6c046089554258af..8bd7570d1ee400242c2a66e20ca1965d6e670318 100644

--- a/third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html

+++ b/third_party/WebKit/LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html

@@ -23,7 +23,7 @@ function checkComputedStyleValue() {

}

e.style.background = 'center / cover red url("dummy://test.png") no-repeat border-box';

-shouldBeEqualToString("e.style.background", 'url("dummy://test.png") 50% 50% / cover no-repeat border-box border-box red');

+shouldBeEqualToString("e.style.background", 'url("dummy://test.png") center center / cover no-repeat border-box border-box red');

shouldBeEqualToString("e.style.backgroundSize", 'cover');

shouldBe("checkStyle()", "true");

shouldBeEqualToString('computedStyle.getPropertyValue("background")', 'rgb(255, 0, 0) url("dummy://test.png") no-repeat scroll 50% 50% / cover border-box border-box');

@@ -32,7 +32,7 @@ shouldBe("checkComputedStyleValue()", "true");

debug("")

e.style.background = 'red 20px / contain url("dummy://test.png") no-repeat padding-box';

-shouldBeEqualToString("e.style.background", 'url("dummy://test.png") 20px 50% / contain no-repeat padding-box padding-box red');

+shouldBeEqualToString("e.style.background", 'url("dummy://test.png") 20px center / contain no-repeat padding-box padding-box red');

shouldBeEqualToString("e.style.backgroundSize", 'contain');

shouldBe("checkStyle()", "true");

shouldBeEqualToString('computedStyle.getPropertyValue("background")', 'rgb(255, 0, 0) url("dummy://test.png") no-repeat scroll 20px 50% / contain padding-box padding-box');

@@ -50,7 +50,7 @@ shouldBe("checkComputedStyleValue()", "true");

debug("")

e.style.background = 'red url("dummy://test.png") repeat top left / 100px 200px border-box content-box';

-shouldBeEqualToString("e.style.background", 'url("dummy://test.png") 0% 0% / 100px 200px repeat border-box content-box red');

+shouldBeEqualToString("e.style.background", 'url("dummy://test.png") left top / 100px 200px repeat border-box content-box red');

shouldBeEqualToString("e.style.backgroundSize", '100px 200px');

shouldBe("checkStyle()", "true");

shouldBeEqualToString('computedStyle.getPropertyValue("background")', 'rgb(255, 0, 0) url("dummy://test.png") repeat scroll 0% 0% / 100px 200px border-box content-box');

@@ -59,7 +59,7 @@ shouldBe("checkComputedStyleValue()", "true");

debug("")

e.style.background = 'red url("dummy://test.png") repeat 50% / auto auto content-box padding-box';

-shouldBeEqualToString("e.style.background", 'url("dummy://test.png") 50% 50% / auto repeat content-box padding-box red');

+shouldBeEqualToString("e.style.background", 'url("dummy://test.png") 50% center / auto repeat content-box padding-box red');

shouldBeEqualToString("e.style.backgroundSize", 'auto');

shouldBe("checkStyle()", "true");

shouldBeEqualToString('computedStyle.getPropertyValue("background")', 'rgb(255, 0, 0) url("dummy://test.png") repeat scroll 50% 50% / auto content-box padding-box');

@@ -77,7 +77,7 @@ shouldBe("checkComputedStyleValue()", "true");

debug("")

e.style.background = 'red repeat scroll padding-box border-box top left / 100px url("dummy://test.png")';

-shouldBeEqualToString("e.style.background", 'url("dummy://test.png") 0% 0% / 100px repeat scroll padding-box border-box red');

+shouldBeEqualToString("e.style.background", 'url("dummy://test.png") left top / 100px repeat scroll padding-box border-box red');

shouldBeEqualToString("e.style.backgroundSize", '100px');

shouldBe("checkStyle()", "true");

shouldBeEqualToString('computedStyle.getPropertyValue("background")', 'rgb(255, 0, 0) url("dummy://test.png") repeat scroll 0% 0% / 100px padding-box border-box');

@@ -86,7 +86,7 @@ shouldBe("checkComputedStyleValue()", "true");

debug("")

e.style.background = '50% / auto fixed url("dummy://test.png") repeat content-box red';

-shouldBeEqualToString("e.style.background", 'url("dummy://test.png") 50% 50% / auto repeat fixed content-box content-box red');

+shouldBeEqualToString("e.style.background", 'url("dummy://test.png") 50% center / auto repeat fixed content-box content-box red');

shouldBeEqualToString("e.style.backgroundSize", 'auto');

shouldBe("checkStyle()", "true");

shouldBeEqualToString('computedStyle.getPropertyValue("background")', 'rgb(255, 0, 0) url("dummy://test.png") repeat fixed 50% 50% / auto content-box content-box');

@@ -95,7 +95,7 @@ shouldBe("checkComputedStyleValue()", "true");

debug("")

e.style.background = "top left / 50%";

-shouldBeEqualToString("e.style.background", '0% 0% / 50%');

+shouldBeEqualToString("e.style.background", 'left top / 50%');

shouldBeEqualToString("e.style.backgroundSize", '50%');

shouldBe("checkStyle()", "true");

shouldBeEqualToString('computedStyle.getPropertyValue("background")', 'rgba(0, 0, 0, 0) none repeat scroll 0% 0% / 50% padding-box border-box');