third_party/WebKit/LayoutTests/fast/backgrounds/background-clip-per-layer.html - Issue 1676513003: Move background/webkit-mask shorthands into CSSPropertyParser

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/backgrounds/background-clip-per-layer.html

Issue 1676513003: Move background/webkit-mask shorthands into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix background-size logic Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/backgrounds/background-clip-per-layer-expected.txt » ('j') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <script src="../../resources/js-test.js"></script>

	4 <div id="test"> </div>

	5 <script>

	6 description("Tests a flag to make background shorthand property not override bac kground-size when it's already set.");
	Timothy Loh 2016/03/07 03:55:07 needs update needs update rwlbuis 2016/03/08 02:51:49 Done. Show quoted text On 2016/03/07 03:55:07, Timothy Loh wrote: > needs update Done. rwlbuis 2016/03/08 02:51:49 Done. Show quoted text On 2016/03/07 03:55:07, Timothy Loh wrote: > needs update Done.
	7

	8 var e = document.getElementById('test');

	9

	10 e.style.background = "url('a') content-box padding-box, url('b') border-box";

	11 //e.style.background = "url('a') border-box";
	Timothy Loh 2016/03/07 03:55:07 remove this? remove this? rwlbuis 2016/03/08 02:51:49 Done. Show quoted text On 2016/03/07 03:55:07, Timothy Loh wrote: > remove this? Done.
	12 shouldBeEqualToString("e.style.backgroundOrigin", 'content-box, border-box');

	13 shouldBeEqualToString("e.style.backgroundClip", 'padding-box, border-box');

	14 debug("")
	Timothy Loh 2016/03/07 03:55:07 does this do anything? does this do anything? rwlbuis 2016/03/08 02:51:49 Just adds a newline to expected result, removed. Show quoted text On 2016/03/07 03:55:07, Timothy Loh wrote: > does this do anything? Just adds a newline to expected result, removed.
	15

	16 </script>

	17 </body>

	18 </html>

OLD	NEW