lib/src/codegen/js_printer.dart - Issue 1676463002: Type annotations instead of closure comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_printer.dart

Issue 1676463002: Type annotations instead of closure comments. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: merged master Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_printer.dart

diff --git a/lib/src/codegen/js_printer.dart b/lib/src/codegen/js_printer.dart

index 50ce6ba4ecc43dcfaf6431aa16059c11f326f34f..3325870303cabdb4775e9cf1be0b8a73970e8f26 100644

--- a/lib/src/codegen/js_printer.dart

+++ b/lib/src/codegen/js_printer.dart

@@ -32,7 +32,9 @@ String writeJsLibrary(

}

var opts = new JS.JavaScriptPrintingOptions(

- allowKeywordsInProperties: true, allowSingleLineIfStatements: true);

+ shouldEmitTypes: true,

+ allowKeywordsInProperties: true,

+ allowSingleLineIfStatements: true);

var jsNamer = new TemporaryNamer(jsTree);

jsTree.accept(new JS.Printer(opts, context, localNamer: jsNamer));

« no previous file with comments | « lib/src/codegen/js_names.dart ('k') | lib/src/codegen/js_typeref_codegen.dart » ('j') | no next file with comments »