Type annotations instead of closure comments.

test/codegen_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Tests code generation.
 /// Runs Dart Dev Compiler on all input in the `codegen` directory and checks
 /// that the output is what we expected.
 library dev_compiler.test.codegen_test;
 
 import 'dart:io';
@@ skipping 60 matching lines @@
       ModuleFormat moduleFormat: ModuleFormat.legacy}) {
     // TODO(jmesserly): add a way to specify flags in the test file, so
     // they're more self-contained.
     var runtimeDir = path.join(path.dirname(testDirectory), 'lib', 'runtime');
     var options = new CompilerOptions(
         codegenOptions: new CodegenOptions(
             outputDir: expectDir,
             emitSourceMaps: sourceMaps,
             closure: closure,
             forceCompile: checkSdk,
+            destructureNamedParams: closure,
             moduleFormat: moduleFormat),
         useColors: false,
         checkSdk: checkSdk,
         runtimeDir: runtimeDir,
         inputBaseDir: inputDir);
     var reporter = createErrorReporter(context, options);
     return new BatchCompiler(context, options, reporter: reporter);
   }
 
   bool compile(BatchCompiler compiler, String filePath) {
@@ skipping 48 matching lines @@
       var outDir = new Directory(path.join(expectDir, dir));
       if (!outDir.existsSync()) outDir.createSync(recursive: true);
 
       var testFiles = _findTests(path.join(inputDir, dir), filePattern);
       for (var filePath in testFiles) {
         if (multitests.contains(filePath)) continue;
 
         var filename = path.basenameWithoutExtension(filePath);
 
         test('$filename.dart', () {
           // TODO(jmesserly): this was added to get some coverage of source maps

[Jennifer Messerly, 2016/02/09 16:41:58]

This TODO is getting more relevant over time eh? :)

What do you think about putting comments at the start of the test file? That's
the V8 trick (and C# too, IIRC). For example:

    // ddc flags: --closure

If that sounds good I can send a CL your way.

The benefit is you won't have to keep editing codegen_test for each new test
that you want to add that has options.

[ochafik, 2016/02/10 18:12:46]

Yes please, would be awesome! (sorry for letting these hacks grow this big :-))

           // and closure annotations.
           // We need a more comprehensive strategy to test them.
           var sourceMaps = filename == 'map_keys';
           var closure = filename == 'closure';
-          var moduleFormat = filename == 'es6_modules'
+          var moduleFormat = filename == 'es6_modules' || closure
               ? ModuleFormat.es6
               : filename == 'node_modules'
                   ? ModuleFormat.node
                   : ModuleFormat.legacy;
           var success;
           // TODO(vsm): Is it okay to reuse the same context here?  If there is
           // overlap between test files, we may need separate ones for each
           // compiler.
           var compiler =
               (sourceMaps || closure || moduleFormat != ModuleFormat.legacy)
@@ skipping 84 matching lines @@
 
 /// An implementation of analysis engine's [Logger] that prints.
 class PrintLogger implements Logger {
   @override void logError(String message, [CaughtException exception]) {
     print('[AnalysisEngine] error $message $exception');
   }
 
   void logInformation(String message, [CaughtException exception]) {}
   void logInformation2(String message, Object exception) {}
 }