android: Don't require aapt to be on the path during builds and tests.

build/android/gyp/apk_install.py

Index: build/android/gyp/apk_install.py
diff --git a/build/android/gyp/apk_install.py b/build/android/gyp/apk_install.py
index ef3032b088cf14e1607ef2a82acc4a131060c519..54fc07a805c9081f8cd1b36985d6e7cacb8f2406 100755
--- a/build/android/gyp/apk_install.py
+++ b/build/android/gyp/apk_install.py
@@ -55,6 +55,8 @@ def RecordInstallMetadata(device, apk_package, metadata_path):
 
 def main(argv):
   parser = optparse.OptionParser()
+  parser.add_option('--android-sdk-tools',
+      help='path to the Android SDK build tools folder')
   parser.add_option('--apk-path',
       help='Path to .apk to install.')
   parser.add_option('--install-record',
@@ -75,7 +77,8 @@ def main(argv):
   constants.SetBuildType(options.configuration_name)
 
   serial_number = device.GetSerialNumber()
-  apk_package = apk_helper.GetPackageName(options.apk_path)
+  apk_package = apk_helper.GetPackageName(options.android_sdk_tools,

[frankf, 2014/02/14 21:59:19]

I don't see the benefit of passing in the android-sdk-tools from gyp compared to
the added complexity of piping it through everywhere. Why not just use the
constant value? aapt usage here shouldn't affect build behavior.

[Nico, 2014/02/14 22:16:56]

Yes, I'm pretty on the fence here too. I went with this approach since
a) The other place calling aapt (
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/...
) did it like this
b) Using the gyp variables as much as possible seems like a good thing

If you think just always using constants.ANDROID_SDK_TOOLS in apk_helper and
passing it in is preferable, I'll gladly change to that, up to you.

+                                          options.apk_path)
 
   metadata_path = '%s.%s.device.time.stamp' % (options.apk_path, serial_number)