android: Don't require aapt to be on the path during builds and tests.

android: Don't require aapt to be on the path during builds and tests.

BUG=330631
R=frankf@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251452

[frankf, 2014-02-14 21:59:18]

lgtm w/ a question

https://codereview.chromium.org/167643002/diff/40001/build/android/gyp/apk_in...
File build/android/gyp/apk_install.py (right):

https://codereview.chromium.org/167643002/diff/40001/build/android/gyp/apk_in...
build/android/gyp/apk_install.py:80: apk_package =
apk_helper.GetPackageName(options.android_sdk_tools,
I don't see the benefit of passing in the android-sdk-tools from gyp compared to
the added complexity of piping it through everywhere. Why not just use the
constant value? aapt usage here shouldn't affect build behavior.

[Nico, 2014-02-14 22:16:56]

Thanks! I'll wait for your reply before I land this.

https://codereview.chromium.org/167643002/diff/40001/build/android/gyp/apk_in...
File build/android/gyp/apk_install.py (right):

https://codereview.chromium.org/167643002/diff/40001/build/android/gyp/apk_in...
build/android/gyp/apk_install.py:80: apk_package =
apk_helper.GetPackageName(options.android_sdk_tools,
On 2014/02/14 21:59:19, frankf wrote:
> I don't see the benefit of passing in the android-sdk-tools from gyp compared
to
> the added complexity of piping it through everywhere. Why not just use the
> constant value? aapt usage here shouldn't affect build behavior.

Yes, I'm pretty on the fence here too. I went with this approach since
a) The other place calling aapt (
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/...
) did it like this
b) Using the gyp variables as much as possible seems like a good thing

If you think just always using constants.ANDROID_SDK_TOOLS in apk_helper and
passing it in is preferable, I'll gladly change to that, up to you.

[frankf, 2014-02-14 22:24:47]

On 2014/02/14 22:16:56, Nico (away Feb 11 - Feb 17) wrote:
> Thanks! I'll wait for your reply before I land this.
> 
>
https://codereview.chromium.org/167643002/diff/40001/build/android/gyp/apk_in...
> File build/android/gyp/apk_install.py (right):
> 
>
https://codereview.chromium.org/167643002/diff/40001/build/android/gyp/apk_in...
> build/android/gyp/apk_install.py:80: apk_package =
> apk_helper.GetPackageName(options.android_sdk_tools,
> On 2014/02/14 21:59:19, frankf wrote:
> > I don't see the benefit of passing in the android-sdk-tools from gyp
compared
> to
> > the added complexity of piping it through everywhere. Why not just use the
> > constant value? aapt usage here shouldn't affect build behavior.
> 
> Yes, I'm pretty on the fence here too. I went with this approach since
> a) The other place calling aapt (
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/...
> ) did it like this
> b) Using the gyp variables as much as possible seems like a good thing
> 
> If you think just always using constants.ANDROID_SDK_TOOLS in apk_helper and
> passing it in is preferable, I'll gladly change to that, up to you.

I just slightly prefer using the constant since it requires less code.

[Nico, 2014-02-14 22:33:15]

On 2014/02/14 22:24:47, frankf wrote:
> On 2014/02/14 22:16:56, Nico (away Feb 11 - Feb 17) wrote:
> > Thanks! I'll wait for your reply before I land this.
> > 
> >
>
https://codereview.chromium.org/167643002/diff/40001/build/android/gyp/apk_in...
> > File build/android/gyp/apk_install.py (right):
> > 
> >
>
https://codereview.chromium.org/167643002/diff/40001/build/android/gyp/apk_in...
> > build/android/gyp/apk_install.py:80: apk_package =
> > apk_helper.GetPackageName(options.android_sdk_tools,
> > On 2014/02/14 21:59:19, frankf wrote:
> > > I don't see the benefit of passing in the android-sdk-tools from gyp
> compared
> > to
> > > the added complexity of piping it through everywhere. Why not just use the
> > > constant value? aapt usage here shouldn't affect build behavior.
> > 
> > Yes, I'm pretty on the fence here too. I went with this approach since
> > a) The other place calling aapt (
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/...
> > ) did it like this
> > b) Using the gyp variables as much as possible seems like a good thing
> > 
> > If you think just always using constants.ANDROID_SDK_TOOLS in apk_helper and
> > passing it in is preferable, I'll gladly change to that, up to you.
> 
> I just slightly prefer using the constant since it requires less code.

Ok, changed. Thanks!

[frankf, 2014-02-14 22:34:11]

lgtm

[Nico, 2014-02-15 00:22:10]

Committed patchset #4 manually as r251452 (presubmit successful).