Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1676413004: Use SetWindowPos on DirectComposition child window. (Closed)

Created:
4 years, 10 months ago by jbauman
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SetWindowPos on DirectComposition child window. With this change we force a repaint on resize, which clears away the white square in the nonclient area left over from window creation. Switching to SetWindowPos adds flexibility in letting us specify SWP_NOCOPYBITS, which is more efficient as the backbuffer contents don't actually matter. BUG=582877 Committed: https://crrev.com/1d9608302c47f63c138f330baafafd38539e77e4 Cr-Commit-Position: refs/heads/master@{#374849}

Patch Set 1 #

Total comments: 1

Patch Set 2 : ; #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/common/gpu/child_window_surface_win.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jbauman
4 years, 10 months ago (2016-02-10 21:07:03 UTC) #2
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/1676413004/diff/1/content/common/gpu/child_window_surface_win.cc File content/common/gpu/child_window_surface_win.cc (right): https://codereview.chromium.org/1676413004/diff/1/content/common/gpu/child_window_surface_win.cc#newcode144 content/common/gpu/child_window_surface_win.cc:144: // Only force a resize and redraw. Could ...
4 years, 10 months ago (2016-02-11 01:07:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676413004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676413004/20001
4 years, 10 months ago (2016-02-11 02:43:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-11 03:28:46 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:34:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d9608302c47f63c138f330baafafd38539e77e4
Cr-Commit-Position: refs/heads/master@{#374849}

Powered by Google App Engine
This is Rietveld 408576698