Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1676403002: Skia serve now supports favicon correctly (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
A + tools/skiaserve/favicon.ico View Binary file 0 comments Download
M tools/skiaserve/skiaserve.cpp View 4 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
joshualitt
ptal
4 years, 10 months ago (2016-02-08 21:31:23 UTC) #3
ethannicholas
On 2016/02/08 21:31:23, joshualitt wrote: > ptal lgtm
4 years, 10 months ago (2016-02-08 21:32:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676403002/1
4 years, 10 months ago (2016-02-08 21:33:29 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 21:57:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/873d624b80b4f4bf08904e356932198dd7c7576c

Powered by Google App Engine
This is Rietveld 408576698