Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: runtime/vm/code_generator.cc

Issue 1676363002: Fix product build on Linux clang. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
diff --git a/runtime/vm/code_generator.cc b/runtime/vm/code_generator.cc
index 54c48c881e0097382e05bbeeeedd1c35edd482ad..5c5c9c9bea3ec8b0468975dd34249a576b4672d7 100644
--- a/runtime/vm/code_generator.cc
+++ b/runtime/vm/code_generator.cc
@@ -708,6 +708,7 @@ DEFINE_RUNTIME_ENTRY(BreakpointRuntimeHandler, 0) {
if (!FLAG_support_debugger) {
UNREACHABLE();
Cutch 2016/02/08 19:02:55 I'm pretty sure all that is needed is a return sta
rmacnak 2016/02/08 19:05:37 Yes, much better.
}
+#if !defined(PRODUCT)
DartFrameIterator iterator;
StackFrame* caller_frame = iterator.NextFrame();
ASSERT(caller_frame != NULL);
@@ -719,6 +720,7 @@ DEFINE_RUNTIME_ENTRY(BreakpointRuntimeHandler, 0) {
UNREACHABLE();
}
arguments.SetReturn(orig_stub);
+#endif // !PRODUCT
}
@@ -726,12 +728,14 @@ DEFINE_RUNTIME_ENTRY(SingleStepHandler, 0) {
if (!FLAG_support_debugger) {
UNREACHABLE();
}
+#if !defined(PRODUCT)
const Error& error =
Error::Handle(isolate->debugger()->DebuggerStepCallback());
if (!error.IsNull()) {
Exceptions::PropagateError(error);
UNREACHABLE();
}
+#endif // !PRODUCT
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698