Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1676363002: Fix product build on Linux clang. (Closed)

Created:
4 years, 10 months ago by rmacnak
Modified:
4 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/code_generator.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
4 years, 10 months ago (2016-02-08 19:00:46 UTC) #2
Cutch
https://codereview.chromium.org/1676363002/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/1676363002/diff/1/runtime/vm/code_generator.cc#newcode709 runtime/vm/code_generator.cc:709: UNREACHABLE(); I'm pretty sure all that is needed is ...
4 years, 10 months ago (2016-02-08 19:02:55 UTC) #3
rmacnak
https://codereview.chromium.org/1676363002/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/1676363002/diff/1/runtime/vm/code_generator.cc#newcode709 runtime/vm/code_generator.cc:709: UNREACHABLE(); On 2016/02/08 19:02:55, Cutch wrote: > I'm pretty ...
4 years, 10 months ago (2016-02-08 19:05:37 UTC) #4
Cutch
lgtm
4 years, 10 months ago (2016-02-08 19:06:15 UTC) #5
rmacnak
4 years, 10 months ago (2016-02-08 19:06:42 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a9428e26bc29fb0836ea253cf61f550f908bbd4c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698