Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1676293002: [interpreter] Workaround for unused frame states. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Workaround for unused frame states. This is a temporary workaround for bytecodes which are not guaranteed to actually use the frame states being created for them. One example for this are runtime calls to intrinsics, or to runtime functions for which the frame state count is zero in Linkage::FrameStateInputCount. This will eventually be reworked into a more generic mechanism that attaches frame states in the BytecodeGraphBuilder::VisitBytecodes iteration method itself, instead of in the individual visitors. R=jarin@chromium.org Committed: https://crrev.com/3c8edd316f97f2e7ca9b52ed5c38d457b3950eed Cr-Commit-Position: refs/heads/master@{#33836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/compiler/bytecode-graph-builder.cc View 4 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-08 14:39:24 UTC) #1
Jarin
lgtm. Thanks for helping me with this.
4 years, 10 months ago (2016-02-09 07:04:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676293002/1
4 years, 10 months ago (2016-02-09 08:25:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 08:40:53 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 08:41:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c8edd316f97f2e7ca9b52ed5c38d457b3950eed
Cr-Commit-Position: refs/heads/master@{#33836}

Powered by Google App Engine
This is Rietveld 408576698