Reland of Change default Windows compiler to VS 2015

Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1680533004/ )

Reason for revert:
The GPU bot problem (a bug with swarming tests on component builds) is fixed with crrev.com/1676943002

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1679693002/ )
>
> Reason for revert:
> This breaks GPU win debug bots (https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/36633 for example, every GPU test is crashing)
>
> Original issue's description:
> > Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1678663002/ )
> >
> > Reason for revert:
> > Issues that forced revert of VS 2015 as default compiler are believed to be fixed.
> >
> > Original issue's description:
> > > Revert of Change default Windows compiler to VS 2015 (patchset #10 id:180001 of https://codereview.chromium.org/1598493004/ )
> > >
> > > Reason for revert:
> > > Speculative for https://code.google.com/p/chromium/issues/detail?id=498544#c20 . Will reland if this doesn't help.
> > >
> > > Original issue's description:
> > > > Change default Windows compiler to VS 2015
> > > >
> > > > The change to get_landmines.py is there because modifying this file
> > > > affects analyze behavior so that all tests run. Changing the printed
> > > > message is purely a side effect.
> > > >
> > > > This change also removes some redundant INCLUDE paths. These are
> > > > unnecessary when building with VS 2015 (because it defaults to the
> > > > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > > > problematically long).
> > > >
> > > > BUG=440500, 584782
> > > >
> > > > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe
> > > > Cr-Commit-Position: refs/heads/master@{#373955}
> > >
> > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,brucedawson@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=440500, 584782
> > >
> > > Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96
> > > Cr-Commit-Position: refs/heads/master@{#374013}
> >
> > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=440500, 584782
> >
> > Committed: https://crrev.com/20e99ecb08da22582d435c1a5bba0a5c96345da3
> > Cr-Commit-Position: refs/heads/master@{#374058}
>
> TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500, 584782
>
> Committed: https://crrev.com/03f6b0af0a3a0127f5e939095157079659ab7cc8
> Cr-Commit-Position: refs/heads/master@{#374062}

TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org,zmo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500, 584782
Committed: https://crrev.com/36f03f2ac1f92b6f41129f013f8a808f7b9127fc
Cr-Commit-Position: refs/heads/master@{#374324}

[brucedawson, 2016-02-09 04:48:09]

Created Reland of Change default Windows compiler to VS 2015

[brucedawson, 2016-02-09 04:51:48]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-02-09 04:53:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676263003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676263003/1

[commit-bot: I haz the power, 2016-02-09 06:35:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-09 06:36:03]

Description was changed from

==========
Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1680533004/ )

Reason for revert:
The GPU bot problem (a bug with swarming tests on component builds) is fixed
with crrev.com/1676943002

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1679693002/ )
> 
> Reason for revert:
> This breaks GPU win debug bots
(https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%2...
for example, every GPU test is crashing)
> 
> Original issue's description:
> > Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1678663002/ )
> >
> > Reason for revert:
> > Issues that forced revert of VS 2015 as default compiler are believed to be
fixed.
> >
> > Original issue's description:
> > > Revert of Change default Windows compiler to VS 2015 (patchset #10
id:180001 of https://codereview.chromium.org/1598493004/ )
> > >
> > > Reason for revert:
> > > Speculative for
https://code.google.com/p/chromium/issues/detail?id=498544#c20 . Will reland if
this doesn't help.
> > >
> > > Original issue's description:
> > > > Change default Windows compiler to VS 2015
> > > >
> > > > The change to get_landmines.py is there because modifying this file
> > > > affects analyze behavior so that all tests run. Changing the printed
> > > > message is purely a side effect.
> > > >
> > > > This change also removes some redundant INCLUDE paths. These are
> > > > unnecessary when building with VS 2015 (because it defaults to the
> > > > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > > > problematically long).
> > > >
> > > > BUG=440500,584782
> > > >
> > > > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe
> > > > Cr-Commit-Position: refs/heads/master@{#373955}
> > >
> > >
TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,bruced...
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=440500,584782
> > >
> > > Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96
> > > Cr-Commit-Position: refs/heads/master@{#374013}
> >
> >
TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis...
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=440500,584782
> >
> > Committed: https://crrev.com/20e99ecb08da22582d435c1a5bba0a5c96345da3
> > Cr-Commit-Position: refs/heads/master@{#374058}
> 
>
TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500,584782
> 
> Committed: https://crrev.com/03f6b0af0a3a0127f5e939095157079659ab7cc8
> Cr-Commit-Position: refs/heads/master@{#374062}

TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,584782
==========

to

==========
Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1680533004/ )

Reason for revert:
The GPU bot problem (a bug with swarming tests on component builds) is fixed
with crrev.com/1676943002

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1679693002/ )
>
> Reason for revert:
> This breaks GPU win debug bots
(https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%2...
for example, every GPU test is crashing)
>
> Original issue's description:
> > Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of
https://codereview.chromium.org/1678663002/ )
> >
> > Reason for revert:
> > Issues that forced revert of VS 2015 as default compiler are believed to be
fixed.
> >
> > Original issue's description:
> > > Revert of Change default Windows compiler to VS 2015 (patchset #10
id:180001 of https://codereview.chromium.org/1598493004/ )
> > >
> > > Reason for revert:
> > > Speculative for
https://code.google.com/p/chromium/issues/detail?id=498544#c20 . Will reland if
this doesn't help.
> > >
> > > Original issue's description:
> > > > Change default Windows compiler to VS 2015
> > > >
> > > > The change to get_landmines.py is there because modifying this file
> > > > affects analyze behavior so that all tests run. Changing the printed
> > > > message is purely a side effect.
> > > >
> > > > This change also removes some redundant INCLUDE paths. These are
> > > > unnecessary when building with VS 2015 (because it defaults to the
> > > > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > > > problematically long).
> > > >
> > > > BUG=440500,584782
> > > >
> > > > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe
> > > > Cr-Commit-Position: refs/heads/master@{#373955}
> > >
> > >
TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,bruced...
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=440500,584782
> > >
> > > Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96
> > > Cr-Commit-Position: refs/heads/master@{#374013}
> >
> >
TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis...
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=440500,584782
> >
> > Committed: https://crrev.com/20e99ecb08da22582d435c1a5bba0a5c96345da3
> > Cr-Commit-Position: refs/heads/master@{#374058}
>
>
TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500,584782
>
> Committed: https://crrev.com/03f6b0af0a3a0127f5e939095157079659ab7cc8
> Cr-Commit-Position: refs/heads/master@{#374062}

TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,584782

Committed: https://crrev.com/36f03f2ac1f92b6f41129f013f8a808f7b9127fc
Cr-Commit-Position: refs/heads/master@{#374324}
==========

[commit-bot: I haz the power, 2016-02-09 06:36:04]

Patchset 1 (id:??) landed as
https://crrev.com/36f03f2ac1f92b6f41129f013f8a808f7b9127fc
Cr-Commit-Position: refs/heads/master@{#374324}

[blundell, 2016-02-09 11:13:27]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1680123002/ by blundell@chromium.org.

The reason for reverting is: Speculative revert to see if it fixes the
"Duplicate COMDAT" compile error; will reland if it doesn't. Googling indicates
that we have fought with "Duplicate COMDAT" errors in the past as part of trying
to bring in VS 2015.

This error occurred in #374346, which is a revert of #374322 due to that CL
causing test failures on Linux. Note that the Windows compiler switch landed in
#374324.

Here is the error in question (from
https://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Bui...):

FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool
link-with-manifests environment.x64 True mojo_system_impl.dll
"C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper
environment.x64 False link.exe /nologo /IMPLIB:mojo_system_impl.dll.lib /DLL
/OUT:mojo_system_impl.dll @mojo_system_impl.dll.rsp" 2 mt.exe rc.exe
"obj\third_party\mojo\mojo_system_impl.mojo_system_impl.dll.intermediate.manifest"
obj\third_party\mojo\mojo_system_impl.mojo_system_impl.dll.generated.manifest
mojo_system_impl2.node_controller.obj : fatal error LNK1179: invalid or corrupt
file: duplicate COMDAT
'??1?$Callback@$$A6AXAEBVPortRef@ports@edk@mojo@@@Z@base@@QEAA@XZ'  .

[brucedawson, 2016-02-09 16:53:39]

On 2016/02/09 11:13:27, blundell wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1680123002/ by mailto:blundell@chromium.org.

Our experience with the FYI VS 2015 builders shows that this link failure is
typically transient and fairly low frequency. The failure rate I have observed
there is less than 1%. The connect bug I filed is here:

https://connect.microsoft.com/VisualStudio/feedback/details/1853228/lnk1179-i...

The response indicates that they think that it is fixed in Update 2, so we'll
have to make a judgment call as to whether we want to accept the failure rate.

[Sébastien Marchand, 2016-02-09 16:56:50]

(this might be a terrible idea) : What about handling this particular case and
having some retry logic when we encounter this error ?

[scottmg, 2016-02-09 18:01:15]

On 2016/02/09 16:53:39, brucedawson wrote:
> On 2016/02/09 11:13:27, blundell wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/1680123002/ by mailto:blundell@chromium.org.
> 
> Our experience with the FYI VS 2015 builders shows that this link failure is
> typically transient and fairly low frequency. The failure rate I have observed
> there is less than 1%. The connect bug I filed is here:
> 
>
https://connect.microsoft.com/VisualStudio/feedback/details/1853228/lnk1179-i...
> 
> The response indicates that they think that it is fixed in Update 2, so we'll
> have to make a judgment call as to whether we want to accept the failure rate.

If it's 1% that's probably too high, that's probably at least one waterfall
failure per day (plus a variety of annoyance on tryjobs).

If it's a lot lower than 1% then... maybe?