Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1676263002: Remove --stop-at flag from several backends. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --stop-at flag from several backends. The flag in question is a debug-only flag supported by full-codegen and Crankshaft only. In it's current form there are some unresolved issues: - The flag is defeated by inlining in Crankshaft. - The flag is not supported by TurboFan. - The flag is not supported by Ignition. Instead of addressing the above issues and increasing maintenance cost for all backends and also given the "slim" test coverage, this CL fully removes the support from all backends. R=bmeurer@chromium.org,jkummerow@chromium.org Committed: https://crrev.com/664110f8826d70226af4a30abaad4a90c5dd034a Cr-Commit-Position: refs/heads/master@{#33817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -124 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Michael Starzinger
Benedikt: PTAL and please sign off on this as TurboFan & Fullcode owner. Jakob: Please ...
4 years, 10 months ago (2016-02-08 12:33:54 UTC) #2
Benedikt Meurer
LGTM. Kill it with fire!
4 years, 10 months ago (2016-02-08 12:41:30 UTC) #3
rmcilroy
LGTM, thanks for cleaning up the comment in the interpreter builtins!
4 years, 10 months ago (2016-02-08 13:01:26 UTC) #4
Jakob Kummerow
lgtm
4 years, 10 months ago (2016-02-08 13:22:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676263002/1
4 years, 10 months ago (2016-02-08 13:55:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 13:57:35 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 13:57:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/664110f8826d70226af4a30abaad4a90c5dd034a
Cr-Commit-Position: refs/heads/master@{#33817}

Powered by Google App Engine
This is Rietveld 408576698