Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 167613002: Revert of [WebsiteSettings] Set view to null on manager to ensure no stale access. (Closed)

Created:
6 years, 10 months ago by hubbe
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tfarina, markusheintz_
Visibility:
Public.

Description

Revert of [WebsiteSettings] Set view to null on manager to ensure no stale access. (https://codereview.chromium.org/162713003/) Reason for revert: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/23000 Original issue's description: > [WebsiteSettings] Set view to null on manager to ensure no stale access. > > R=leng@chromium.org, markusheintz@chromium.org > BUG=343234 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251392 TBR=leng@chromium.org,markusheintz@chromium.org,gbillock@chromium.org NOTREECHECKS=true NOTRY=true BUG=343234 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 5 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_view.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hubbe
Created Revert of [WebsiteSettings] Set view to null on manager to ensure no stale access.
6 years, 10 months ago (2014-02-14 20:17:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/167613002/1
6 years, 10 months ago (2014-02-14 20:20:32 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 20:22:29 UTC) #3
Message was sent while issue was closed.
Change committed as 251409

Powered by Google App Engine
This is Rietveld 408576698