Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: tests/ImageFilterTest.cpp

Issue 1676103002: msan: initialize buffer BlurLargeImage blurs (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: missed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/dm_flags.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/ImageFilterTest.cpp
diff --git a/tests/ImageFilterTest.cpp b/tests/ImageFilterTest.cpp
index 68a95fcb170d4604017f95e0f72380ad3600be12..c4e431f4ed3053d7ab9f5eb4d2514096ca92f891 100644
--- a/tests/ImageFilterTest.cpp
+++ b/tests/ImageFilterTest.cpp
@@ -185,7 +185,7 @@ DEF_TEST(ImageFilter, reporter) {
SkAutoTUnref<SkImageFilter> gray(make_grayscale(nullptr, nullptr));
REPORTER_ASSERT(reporter, true == gray->asColorFilter(nullptr));
}
-
+
{
// Check that a colorfilterimage filter without a crop rect but with an input
// that is another colorfilterimage can be expressed as a colorfilter (composed).
@@ -887,7 +887,7 @@ DEF_TEST(ImageFilterCrossProcessPictureImageFilter, reporter) {
pixel = *bitmap.getAddr32(0, 0);
// If the security precautions are enabled, the result here should not be green, since the
// filter draws nothing.
- REPORTER_ASSERT(reporter, SkPicture::PictureIOSecurityPrecautionsEnabled()
+ REPORTER_ASSERT(reporter, SkPicture::PictureIOSecurityPrecautionsEnabled()
? pixel != SK_ColorGREEN : pixel == SK_ColorGREEN);
}
@@ -1274,6 +1274,7 @@ static void test_large_blur_input(skiatest::Reporter* reporter, SkCanvas* canvas
#endif
largeBmp.allocN32Pixels(largeW, largeH);
+ largeBmp.eraseColor(0);
if (!largeBmp.getPixels()) {
ERRORF(reporter, "Failed to allocate large bmp.");
return;
« no previous file with comments | « no previous file | tools/dm_flags.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698