Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 167603002: Implement 'will-change' parsing (Closed)

Created:
6 years, 10 months ago by ajuma
Modified:
6 years, 10 months ago
Reviewers:
eseidel
CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, esprehn, ojan
Visibility:
Public.

Description

Implement 'will-change' parsing This implements parsing for the 'will-change' CSS property. This property is protected by a runtime flag. Intent-to-implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/M62y2nKZ-gE Spec: http://tabatkins.github.io/specs/css-will-change/ BUG=313532 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167394

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -1 line) Patch
A LayoutTests/compositing/will-change/parse-will-change.html View 1 chunk +146 lines, -0 lines 0 comments Download
A LayoutTests/compositing/will-change/parse-will-change-expected.txt View 1 chunk +51 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 3 chunks +17 lines, -0 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/css/RuntimeCSSEnabled.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 chunks +60 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 chunks +38 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +9 lines, -0 lines 1 comment Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
A Source/core/rendering/style/StyleWillChangeData.h View 1 chunk +42 lines, -0 lines 0 comments Download
A Source/core/rendering/style/StyleWillChangeData.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ajuma
6 years, 10 months ago (2014-02-18 21:55:58 UTC) #1
eseidel
lgtm https://codereview.chromium.org/167603002/diff/180001/Source/core/rendering/style/RenderStyle.h File Source/core/rendering/style/RenderStyle.h (right): https://codereview.chromium.org/167603002/diff/180001/Source/core/rendering/style/RenderStyle.h#newcode1383 Source/core/rendering/style/RenderStyle.h:1383: void setWillChangeProperties(const Vector<CSSPropertyID>& properties) { SET_VAR(rareNonInheritedData.access()->m_willChange, m_properties, properties); ...
6 years, 10 months ago (2014-02-18 23:33:52 UTC) #2
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 10 months ago (2014-02-19 00:12:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/167603002/180001
6 years, 10 months ago (2014-02-19 00:12:57 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 03:22:12 UTC) #5
Message was sent while issue was closed.
Change committed as 167394

Powered by Google App Engine
This is Rietveld 408576698