Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

Issue 1675973002: Prefer to use the OES_depth24 extension for WebGL's depth-only back buffers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
diff --git a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
index 87a2789becf24be50f74a058344e569300118688..c42faa8fa3ed28edd72aca2e2666d749b3e2b9df 100644
--- a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
+++ b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
@@ -167,12 +167,19 @@ public:
void addNewMailboxCallback(PassOwnPtr<Closure> closure) { m_newMailboxCallback = std::move(closure); }
protected: // For unittests
+ struct PLATFORM_EXPORT SupportedExtensions {
+ SupportedExtensions();
+
+ bool multisample;
+ bool packedDepthStencil;
+ bool depth24;
+ bool discardFramebuffer;
+ };
+
DrawingBuffer(
PassOwnPtr<WebGraphicsContext3D>,
PassOwnPtr<Extensions3DUtil>,
- bool multisampleExtensionSupported,
- bool packedDepthStencilExtensionSupported,
- bool discardFramebufferSupported,
+ const SupportedExtensions&,
PreserveDrawingBuffer,
WebGraphicsContext3D::Attributes requestedAttributes);
@@ -299,6 +306,7 @@ private:
WebGraphicsContext3D::Attributes m_requestedAttributes;
bool m_multisampleExtensionSupported;
bool m_packedDepthStencilExtensionSupported;
+ bool m_depth24ExtensionSupported;
bool m_discardFramebufferSupported;
Platform3DObject m_fbo;
// DrawingBuffer's output is double-buffered. m_colorBuffer is the back buffer.
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698