Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 167593003: fix excesive number of mutexes created by sandbox (Closed)

Created:
6 years, 10 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

fix excesive number of mutexes created by sandbox The |cient_control->server_alive| mutex was being created for each target (child) process and leaked (that part is necessary). Instead a single mutex can be reused for all targets. R=rvargas BUG=331241 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252782

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M sandbox/win/src/sharedmem_ipc_server.cc View 1 3 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cpu_(ooo_6.6-7.5)
I used the old style to be consistent with the surrounding code and other parts ...
6 years, 10 months ago (2014-02-20 02:44:19 UTC) #1
rvargas (doing something else)
lgtm https://codereview.chromium.org/167593003/diff/1/sandbox/win/src/sharedmem_ipc_server.cc File sandbox/win/src/sharedmem_ipc_server.cc (right): https://codereview.chromium.org/167593003/diff/1/sandbox/win/src/sharedmem_ipc_server.cc#newcode16 sandbox/win/src/sharedmem_ipc_server.cc:16: // This handle must not be closed. nit: ...
6 years, 10 months ago (2014-02-20 15:45:53 UTC) #2
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 10 months ago (2014-02-22 00:33:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/167593003/90001
6 years, 10 months ago (2014-02-22 00:36:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/167593003/90001
6 years, 10 months ago (2014-02-22 01:33:37 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 08:31:37 UTC) #6
Message was sent while issue was closed.
Change committed as 252782

Powered by Google App Engine
This is Rietveld 408576698