Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1675903002: fix int type coercion in asm to wasm (Closed)

Created:
4 years, 10 months ago by aseemgarg
Modified:
4 years, 10 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@indirectFunctions
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

fix int type coercion in asm to wasm R=bradnelson@chromium.org BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=asm-wasm.js LOG=N Committed: https://crrev.com/0e22baac120c3ee3ab79d6239cff4730fce6af38 Cr-Commit-Position: refs/heads/master@{#33793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/wasm/asm-wasm-builder.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
aseemgarg
4 years, 10 months ago (2016-02-06 00:05:01 UTC) #1
bradnelson
lgtm
4 years, 10 months ago (2016-02-06 00:33:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675903002/1
4 years, 10 months ago (2016-02-06 00:33:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-06 00:56:36 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-06 00:57:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e22baac120c3ee3ab79d6239cff4730fce6af38
Cr-Commit-Position: refs/heads/master@{#33793}

Powered by Google App Engine
This is Rietveld 408576698