Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1559)

Issue 16759002: Disable Activity Log in non-AL browser tests (Closed)

Created:
7 years, 6 months ago by felt
Modified:
7 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Some of the API tests generate so many loggable events that the Activity Log needs a really long time to flush, causing test to time out. http://build.chromium.org/p/chromium.win/builders/Win%20Aura%20Tests%20%283%29/builds/3502/steps/browser_tests/logs/HostSubsets - Added code to reset command line flags - Commented out some code in activity_log.cc because extension_service->IsExtensionEnabled is always returning true for an unknown reason BUG=238256 R=kalman@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205339 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205353

Patch Set 1 #

Patch Set 2 : Testing #

Patch Set 3 : Commented out code #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M chrome/browser/extensions/activity_log/activity_log.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc View 1 2 3 4 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
felt
ben, please review
7 years, 6 months ago (2013-06-10 21:29:55 UTC) #1
not at google - send to devlin
lgtm wish there was a scoped command line class
7 years, 6 months ago (2013-06-10 21:33:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/16759002/1
7 years, 6 months ago (2013-06-10 21:38:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/16759002/9001
7 years, 6 months ago (2013-06-10 23:07:55 UTC) #4
raymes
Committed patchset #4 manually as r205339.
7 years, 6 months ago (2013-06-10 23:13:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/16759002/13004
7 years, 6 months ago (2013-06-10 23:31:03 UTC) #6
felt
On 2013/06/10 23:31:03, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 6 months ago (2013-06-10 23:32:43 UTC) #7
raymes1
On 2013/06/10 23:32:43, felt wrote: > On 2013/06/10 23:31:03, I haz the power (commit-bot) wrote: ...
7 years, 6 months ago (2013-06-10 23:33:54 UTC) #8
raymes
Committed patchset #5 manually as r205353.
7 years, 6 months ago (2013-06-10 23:57:31 UTC) #9
benjhayden
7 years, 6 months ago (2013-06-11 13:01:53 UTC) #10
Message was sent while issue was closed.
Could this CL be related to this bug?
http://crbug.com/248438

Powered by Google App Engine
This is Rietveld 408576698