Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1675843002: SkPngCodec clean-ups (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPngCodec clean-ups Use png_read_row() instead of png_read_rows(1). All png_read_rows() does is call png_read_row() in a loop. This comes from Leon's comment in: https://codereview.chromium.org/1671003004/ Also there is a bit of refactoring. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1675843002 Committed: https://skia.googlesource.com/skia/+/60dcd3cb85797b555e47f3e66de81728a2eca40f

Patch Set 1 : #

Patch Set 2 : Rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -29 lines) Patch
M src/codec/SkPngCodec.cpp View 1 6 chunks +21 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
msarett
4 years, 10 months ago (2016-02-05 22:30:38 UTC) #5
scroggo
lgtm
4 years, 10 months ago (2016-02-05 22:36:42 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 1673663002 Patch 200001). Please resolve the dependency and ...
4 years, 10 months ago (2016-02-05 22:38:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675843002/60001
4 years, 10 months ago (2016-02-05 22:41:24 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 23:13:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://skia.googlesource.com/skia/+/60dcd3cb85797b555e47f3e66de81728a2eca40f

Powered by Google App Engine
This is Rietveld 408576698