Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 167583002: Setuid sandbox: exit(2) on SIGABRT (Closed)

Created:
6 years, 10 months ago by jln (very slow on Chromium)
Modified:
6 years, 10 months ago
Reviewers:
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Setuid sandbox: exit(2) on SIGABRT The setuid sandbox waits on its one child and then dies afterwards. When receiving SIGABRT, instead of dumping core, simply exit the process. There is no interesting information to be gathered from knowing that the process is inside waitid(2), one should look at the child process instead. This patch is in hope to reduce red herrings. BUG=334345 TBR=jorgelo NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251459

Patch Set 1 #

Patch Set 2 : Ignore return value more explicitly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M sandbox/linux/suid/sandbox.c View 1 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 10 months ago (2014-02-14 21:29:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/167583002/10002
6 years, 10 months ago (2014-02-14 21:32:21 UTC) #2
jln (very slow on Chromium)
6 years, 10 months ago (2014-02-15 00:42:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r251459 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698