Force bleed avoidance for some background image rendering

third_party/WebKit/Source/core/paint/BoxDecorationData.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/BoxDecorationData.h"
 
 #include "core/layout/LayoutBox.h"
+#include "core/paint/BoxPainter.h"
 #include "core/style/BorderEdge.h"
 #include "core/style/ComputedStyle.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/graphics/GraphicsContext.h"
 
 namespace blink {
 
 BoxDecorationData::BoxDecorationData(const LayoutBox& layoutBox)
 {
     backgroundColor = layoutBox.style()->visitedDependentColor(CSSPropertyBackgroundColor);
@@ skipping 22 matching lines @@
 } // anonymous namespace
 
 BackgroundBleedAvoidance BoxDecorationData::determineBackgroundBleedAvoidance(const LayoutBox& layoutBox)
 {
     if (layoutBox.isDocumentElement())
         return BackgroundBleedNone;
 
     if (!hasBackground)
         return BackgroundBleedNone;
 
-    if (!hasBorderDecoration || !layoutBox.style()->hasBorderRadius() || layoutBox.canRenderBorderImage()) {
+    const ComputedStyle& boxStyle = layoutBox.styleRef();
+    const bool hasBorderRadius = boxStyle.hasBorderRadius();
+    if (!hasBorderDecoration || !hasBorderRadius || layoutBox.canRenderBorderImage()) {
         if (layoutBox.backgroundShouldAlwaysBeClipped())
             return BackgroundBleedClipOnly;
+        // Border radius clipping may require layer bleed avoidance if we are going to draw
+        // an image over something else, because we do not want the antialiasing to lead to bleeding
+        if (boxStyle.hasBackgroundImage() && hasBorderRadius) {

[Stephen Chennney, 2016/02/12 22:07:54]

Have to make sure we have the background image before testing for opaque.

+            // But if the top layer is opaque for the purposes of background painting, we do not
+            // need the bleed avoidance because we will not paint anything behind the top layer.
+            if (!BoxPainter::isFillLayerOpaque(layoutBox.style()->backgroundLayers(), layoutBox))

[Stephen Chennney, 2016/02/12 22:07:54]

Have to use the same test as used in BoxPainter.

+                return BackgroundBleedClipLayer;
+        }
         return BackgroundBleedNone;
     }
 
-    if (borderObscuresBackgroundEdge(*layoutBox.style()))
+    if (borderObscuresBackgroundEdge(boxStyle))
         return BackgroundBleedShrinkBackground;
 
     return BackgroundBleedClipLayer;
 }
 
 } // namespace blink