Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1675803004: Try to get LayoutUnit.h compiling on clang/win bots after VS2015 switch. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
brucedawson
CC:
chromium-reviews, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to get LayoutUnit.h compiling on clang/win bots after VS2015 switch. BUG=82385, 498544 TBR=brucedawson@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e09339b1dbaa8e15d45653bf240c8e2ebfcbaeb0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/LayoutUnit.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 10 months ago (2016-02-06 04:58:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675803004/1
4 years, 10 months ago (2016-02-06 04:59:00 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e09339b1dbaa8e15d45653bf240c8e2ebfcbaeb0 Cr-Commit-Position: refs/heads/master@{#374008}
4 years, 10 months ago (2016-02-06 05:16:29 UTC) #5
Nico
Committed patchset #1 (id:1) manually as e09339b1dbaa8e15d45653bf240c8e2ebfcbaeb0 (presubmit successful).
4 years, 10 months ago (2016-02-06 05:17:09 UTC) #7
brucedawson
4 years, 10 months ago (2016-02-06 08:07:52 UTC) #8
Message was sent while issue was closed.
Thanks for the fix - I'm glad you were up to take a look.

lgtm

Powered by Google App Engine
This is Rietveld 408576698