Issue 16758007: Make sure CallIC is in monomorphic state when starting profiling in NativeAccessorNameInProfile2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16758007: Make sure CallIC is in monomorphic state when starting profiling in NativeAccessorNameInProfile2 (Closed)

Created:
7 years, 6 months ago by yurys

Modified:
7 years, 6 months ago

Reviewers:
loislo, alph, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make sure CallIC is in monomorphic state when starting profiling in NativeAccessorNameInProfile2 Changed cctest/test-cpu-profiler/NativeAccessorNameInProfile2 to make a few warm-up cycles before starting profiler so that accessor invocations performed via monomorphic inline caches and slow paths traces do not distort the profile. Drive-by: removed logging code that was used to diagnose NativeAccessorNameInProfile2 failures on Windows. BUG=None R=jkummerow@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15055

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -20 lines)			Patch
	M	test/cctest/test-cpu-profiler.cc	View		7 chunks	+19 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

7 years, 6 months ago (2013-06-11 08:32:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r15055 (presubmit successful).

Expand Messages | Collapse Messages