Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: src/objects-inl.h

Issue 1675663002: Revert of [es7] refactor and fix Object.values() / Object.entries() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/harmony/object-entries.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 2357 matching lines...) Expand 10 before | Expand all | Expand 10 after
2368 DCHECK(index >= 0 && index < this->length()); 2368 DCHECK(index >= 0 && index < this->length());
2369 DCHECK(reinterpret_cast<Object*>(value)->IsSmi()); 2369 DCHECK(reinterpret_cast<Object*>(value)->IsSmi());
2370 int offset = kHeaderSize + index * kPointerSize; 2370 int offset = kHeaderSize + index * kPointerSize;
2371 WRITE_FIELD(this, offset, value); 2371 WRITE_FIELD(this, offset, value);
2372 } 2372 }
2373 2373
2374 2374
2375 void FixedArray::set(int index, Object* value) { 2375 void FixedArray::set(int index, Object* value) {
2376 DCHECK_NE(GetHeap()->fixed_cow_array_map(), map()); 2376 DCHECK_NE(GetHeap()->fixed_cow_array_map(), map());
2377 DCHECK(IsFixedArray()); 2377 DCHECK(IsFixedArray());
2378 DCHECK_GE(index, 0); 2378 DCHECK(index >= 0 && index < this->length());
2379 DCHECK_LT(index, this->length());
2380 int offset = kHeaderSize + index * kPointerSize; 2379 int offset = kHeaderSize + index * kPointerSize;
2381 WRITE_FIELD(this, offset, value); 2380 WRITE_FIELD(this, offset, value);
2382 WRITE_BARRIER(GetHeap(), this, offset, value); 2381 WRITE_BARRIER(GetHeap(), this, offset, value);
2383 } 2382 }
2384 2383
2385 2384
2386 double FixedDoubleArray::get_scalar(int index) { 2385 double FixedDoubleArray::get_scalar(int index) {
2387 DCHECK(map() != GetHeap()->fixed_cow_array_map() && 2386 DCHECK(map() != GetHeap()->fixed_cow_array_map() &&
2388 map() != GetHeap()->fixed_array_map()); 2387 map() != GetHeap()->fixed_array_map());
2389 DCHECK(index >= 0 && index < this->length()); 2388 DCHECK(index >= 0 && index < this->length());
(...skipping 5486 matching lines...) Expand 10 before | Expand all | Expand 10 after
7876 #undef WRITE_INT64_FIELD 7875 #undef WRITE_INT64_FIELD
7877 #undef READ_BYTE_FIELD 7876 #undef READ_BYTE_FIELD
7878 #undef WRITE_BYTE_FIELD 7877 #undef WRITE_BYTE_FIELD
7879 #undef NOBARRIER_READ_BYTE_FIELD 7878 #undef NOBARRIER_READ_BYTE_FIELD
7880 #undef NOBARRIER_WRITE_BYTE_FIELD 7879 #undef NOBARRIER_WRITE_BYTE_FIELD
7881 7880
7882 } // namespace internal 7881 } // namespace internal
7883 } // namespace v8 7882 } // namespace v8
7884 7883
7885 #endif // V8_OBJECTS_INL_H_ 7884 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/harmony/object-entries.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698