Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1675663002: Revert of [es7] refactor and fix Object.values() / Object.entries() (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es7] refactor and fix Object.values() / Object.entries() (patchset #6 id:100001 of https://codereview.chromium.org/1637753004/ ) Reason for revert: [Sheriff] Breaks gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/1642 Original issue's description: > [es7] refactor and fix Object.values() / Object.entries() > > Previously, Object.values() and Object.entries() were piggy-backing on > Object.keys(). This meant that they would pre-filter non-enumerable properties, > violating the runtime behaviour of the methods. Unfortunately, this does not > match the current proposal text. > > Also incorporates several tests verifying this behaviour based on tests included > in the ChakraCore implementation. > > BUG=v8:4663 > LOG=N > R=adamk@chromium.org, rossberg@chromium.org, littledan@chromium.org > > Committed: https://crrev.com/5c5ccd9d7f8693990d1a9eb26ba3a94f376dcf0b > Cr-Commit-Position: refs/heads/master@{#33782} TBR=littledan@chromium.org,adamk@chromium.org,cbruni@chromium.org,rossberg@chromium.org,caitpotter88@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4663 Committed: https://crrev.com/bdfcc61325af0cb33e8a5f79a35975512f8e8d8e Cr-Commit-Position: refs/heads/master@{#33787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -416 lines) Patch
M src/builtins.cc View 2 chunks +34 lines, -7 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/harmony/object-entries.js View 5 chunks +1 line, -177 lines 0 comments Download
M test/mjsunit/harmony/object-values.js View 5 chunks +1 line, -166 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [es7] refactor and fix Object.values() / Object.entries()
4 years, 10 months ago (2016-02-05 15:35:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675663002/1
4 years, 10 months ago (2016-02-05 15:35:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 15:35:30 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 15:36:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdfcc61325af0cb33e8a5f79a35975512f8e8d8e
Cr-Commit-Position: refs/heads/master@{#33787}

Powered by Google App Engine
This is Rietveld 408576698