Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: content/child/web_url_loader_impl_unittest.cc

Issue 1675633002: WebTaskRunnerImpl to take a TaskQueue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/blink_platform_impl.cc ('k') | content/renderer/renderer_blink_platform_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/web_url_loader_impl_unittest.cc
diff --git a/content/child/web_url_loader_impl_unittest.cc b/content/child/web_url_loader_impl_unittest.cc
index 139544b205338b1aa00660df50373ab57a0a6b51..242017c01fe21ae933b67faf9051a357dfc8b371 100644
--- a/content/child/web_url_loader_impl_unittest.cc
+++ b/content/child/web_url_loader_impl_unittest.cc
@@ -14,8 +14,11 @@
#include "base/memory/weak_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/single_thread_task_runner.h"
+#include "base/time/default_tick_clock.h"
#include "base/time/time.h"
+#include "components/scheduler/child/scheduler_tqm_delegate_impl.h"
#include "components/scheduler/child/web_task_runner_impl.h"
+#include "components/scheduler/child/worker_scheduler.h"
#include "content/child/request_extra_data.h"
#include "content/child/request_info.h"
#include "content/child/resource_dispatcher.h"
@@ -105,13 +108,11 @@ class TestResourceDispatcher : public ResourceDispatcher {
class TestWebURLLoaderClient : public blink::WebURLLoaderClient {
public:
- TestWebURLLoaderClient(
- ResourceDispatcher* dispatcher,
- scoped_refptr<base::SingleThreadTaskRunner> task_runner)
- : loader_(
- new WebURLLoaderImpl(
- dispatcher,
- make_scoped_ptr(new scheduler::WebTaskRunnerImpl(task_runner)))),
+ TestWebURLLoaderClient(ResourceDispatcher* dispatcher,
+ scoped_refptr<scheduler::TaskQueue> task_runner)
+ : loader_(new WebURLLoaderImpl(
+ dispatcher,
+ make_scoped_ptr(new scheduler::WebTaskRunnerImpl(task_runner)))),
expect_multipart_response_(false),
delete_on_receive_redirect_(false),
delete_on_receive_response_(false),
@@ -260,7 +261,15 @@ class TestWebURLLoaderClient : public blink::WebURLLoaderClient {
class WebURLLoaderImplTest : public testing::Test {
public:
explicit WebURLLoaderImplTest()
- : client_(&dispatcher_, message_loop_.task_runner()) {}
+ : worker_scheduler_(scheduler::WorkerScheduler::Create(
+ scheduler::SchedulerTqmDelegateImpl::Create(
+ &message_loop_,
+ make_scoped_ptr(new base::DefaultTickClock())))) {
+ worker_scheduler_->Init();
+ client_.reset(new TestWebURLLoaderClient(
+ &dispatcher_, worker_scheduler_->DefaultTaskRunner()));
+ }
+
~WebURLLoaderImplTest() override {}
void DoStartAsyncRequest() {
@@ -367,15 +376,18 @@ class WebURLLoaderImplTest : public testing::Test {
EXPECT_NE(kMultipartResponse, client()->received_data());
}
- TestWebURLLoaderClient* client() { return &client_; }
+ TestWebURLLoaderClient* client() { return client_.get(); }
TestResourceDispatcher* dispatcher() { return &dispatcher_; }
RequestPeer* peer() { return dispatcher()->peer(); }
base::MessageLoop* message_loop() { return &message_loop_; }
private:
base::MessageLoop message_loop_;
+ // WorkerScheduler is needed because WebURLLoaderImpl needs a
+ // scheduler::TaskQueue.
+ scoped_ptr<scheduler::WorkerScheduler> worker_scheduler_;
TestResourceDispatcher dispatcher_;
- TestWebURLLoaderClient client_;
+ scoped_ptr<TestWebURLLoaderClient> client_;
};
TEST_F(WebURLLoaderImplTest, Success) {
« no previous file with comments | « content/child/blink_platform_impl.cc ('k') | content/renderer/renderer_blink_platform_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698