Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1675633002: WebTaskRunnerImpl to take a TaskQueue (Closed)

Created:
4 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 10 months ago
Reviewers:
Sami, no sievers
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, jam, scheduler-bugs_chromium.org, mlamouri+watch-content_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebTaskRunnerImpl to take a TaskQueue We later want to wire virtual time into blink via the WebTaskRunner so we need WebTaskRunnerImpl to take a TaskQueue instead of a base::SingleThreadTaskRunner. Unfortunately I had to implement an ugly wrapping class in CompositorWorkerScheduler, but I hope we can get rid of that soon. BUG=546953 Committed: https://crrev.com/f61bf5d084ef1f027a17874c5425837530b4ada0 Cr-Commit-Position: refs/heads/master@{#374162}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix WebURLLoaderImplTest #

Patch Set 3 : Fix the CHECK #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -76 lines) Patch
M components/scheduler/child/child_scheduler.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/scheduler/child/compositor_worker_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/compositor_worker_scheduler.cc View 2 chunks +97 lines, -3 lines 0 comments Download
M components/scheduler/child/web_scheduler_impl.h View 3 chunks +5 lines, -10 lines 0 comments Download
M components/scheduler/child/web_scheduler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/scheduler/child/web_task_runner_impl.h View 1 2 chunks +3 lines, -11 lines 0 comments Download
M components/scheduler/child/web_task_runner_impl.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/scheduler/child/worker_scheduler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/worker_scheduler_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 1 2 4 chunks +22 lines, -10 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/test/fake_renderer_scheduler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/fake_renderer_scheduler.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 34 (16 generated)
alex clarke (OOO till 29th)
PTAL
4 years, 10 months ago (2016-02-05 14:02:53 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675633002/1
4 years, 10 months ago (2016-02-05 14:03:14 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/112099)
4 years, 10 months ago (2016-02-05 14:18:18 UTC) #7
Sami
lgtm, thanks for the cleanup. https://codereview.chromium.org/1675633002/diff/1/components/scheduler/child/web_task_runner_impl.h File components/scheduler/child/web_task_runner_impl.h (right): https://codereview.chromium.org/1675633002/diff/1/components/scheduler/child/web_task_runner_impl.h#newcode5 components/scheduler/child/web_task_runner_impl.h:5: #ifndef COMPONENTS_SCHEDULER_CHILD_WEB_task_queue_H_ Probably did ...
4 years, 10 months ago (2016-02-05 14:19:36 UTC) #8
alex clarke (OOO till 29th)
Thanks https://codereview.chromium.org/1675633002/diff/1/components/scheduler/child/web_task_runner_impl.h File components/scheduler/child/web_task_runner_impl.h (right): https://codereview.chromium.org/1675633002/diff/1/components/scheduler/child/web_task_runner_impl.h#newcode5 components/scheduler/child/web_task_runner_impl.h:5: #ifndef COMPONENTS_SCHEDULER_CHILD_WEB_task_queue_H_ On 2016/02/05 14:19:36, Sami wrote: > ...
4 years, 10 months ago (2016-02-05 14:47:02 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675633002/20001
4 years, 10 months ago (2016-02-05 14:47:28 UTC) #11
alex clarke (OOO till 29th)
+jochen@ for content/ OWNERS review.
4 years, 10 months ago (2016-02-05 14:49:52 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/175827)
4 years, 10 months ago (2016-02-05 15:11:26 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675633002/40001
4 years, 10 months ago (2016-02-05 15:27:08 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-05 16:55:43 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675633002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675633002/60001
4 years, 10 months ago (2016-02-08 10:15:30 UTC) #21
alex clarke (OOO till 29th)
Looks like Jochen and Mike west are traveling. Daniel could you please do an OWNERS ...
4 years, 10 months ago (2016-02-08 10:32:09 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 11:48:39 UTC) #25
no sievers
content lgtm
4 years, 10 months ago (2016-02-08 18:40:25 UTC) #26
alex clarke (OOO till 29th)
Thanks all.
4 years, 10 months ago (2016-02-08 20:13:14 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675633002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675633002/60001
4 years, 10 months ago (2016-02-08 20:19:51 UTC) #30
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-08 20:43:58 UTC) #32
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 20:46:52 UTC) #34
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f61bf5d084ef1f027a17874c5425837530b4ada0
Cr-Commit-Position: refs/heads/master@{#374162}

Powered by Google App Engine
This is Rietveld 408576698