Make DocumentType return empty publicId by default

Make DocumentType return empty publicId by default

Return empty publicId, systemId by default to be conforming to DOM4 spec:

Unless explicitly given when a doctype is created, its public ID and system ID are the empty string.
http://dom.spec.whatwg.org/#documenttype

This matches Firefox.

BUG=342564
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167625

[rwlbuis, 2014-02-18 18:07:46]

PTAL.

[rwlbuis, 2014-02-20 21:36:11]

Latest patchset now contains a test. After more testing, Firefox has the
behavior from this patch while IE11 has the old behavior, returning null. We
probably need to make a decision at some point, either go with this or close the
bug. This new behavior does seem to be correct looking at the spec AFAICS.

[abarth-chromium, 2014-02-21 07:40:49]

Doesn't seem like a huge deal either way.  @arv: Would you be willing to pick?

[arv (Not doing code reviews), 2014-02-21 15:06:51]

LGTM

Matching the spec is better than not matching even though this change has no
practical impact.

https://codereview.chromium.org/167563002/diff/210001/LayoutTests/fast/doctyp...
File LayoutTests/fast/doctypes/xml-doctype.xhtml (right):

https://codereview.chromium.org/167563002/diff/210001/LayoutTests/fast/doctyp...
LayoutTests/fast/doctypes/xml-doctype.xhtml:25: if (document.doctype.publicId ==
'')
Ad-hoc tests :'(

[rwlbuis, 2014-02-21 15:42:03]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-02-21 15:42:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/167563002/210001

[commit-bot: I haz the power, 2014-02-21 18:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 18:23:27]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[commit-bot: I haz the power, 2014-02-21 18:23:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 18:23:33]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[rwlbuis, 2014-02-21 18:34:46]

Oops, need more support :) tkent, can you have a look?

[abarth-chromium, 2014-02-21 18:37:33]

I think the commit-bot is just borken

[Inactive, 2014-02-21 18:52:47]

lgtm

[commit-bot: I haz the power, 2014-02-21 18:52:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/167563002/210001

[commit-bot: I haz the power, 2014-02-21 19:12:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/167563002/210001

[commit-bot: I haz the power, 2014-02-21 23:09:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 23:09:17]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[rwlbuis, 2014-02-21 23:14:49]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-02-21 23:15:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/167563002/210001

[commit-bot: I haz the power, 2014-02-22 02:06:57]

Change committed as 167625