third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h - Issue 1675613002: service worker: use 200 OK for update requests even in the no update case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

Issue 1675613002: service worker: use 200 OK for update requests even in the no update case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asan and fix win compile? Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/service_worker/embedded_worker_dispatcher.cc ('k') | third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

index 78a46de3d3d88cc7a9cf2d1de609736978b457a9..c40cd4ae0fb59324ecc1f638d032aa11ef5814d9 100644

--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

@@ -62,6 +62,7 @@ public:

// WebEmbeddedWorker overrides.

void startWorkerContext(const WebEmbeddedWorkerStartData&) override;

void terminateWorkerContext() override;

+ void resumeAfterDownload() override;

void attachDevTools(const WebString& hostId, int sessionId) override;

void reattachDevTools(const WebString& hostId, int sessionId, const WebString& savedState) override;

void detachDevTools() override;

@@ -121,11 +122,16 @@ private:

bool m_askedToTerminate;

enum WaitingForDebuggerState {

- WaitingForDebuggerBeforeLoadingScript,

- WaitingForDebuggerAfterScriptLoaded,

+ WaitingForDebugger,

NotWaitingForDebugger

};

+ enum {

+ DontPauseAfterDownload,

+ DoPauseAfterDownload,

+ IsPausedAfterDownload

+ } m_pauseAfterDownloadState;

WaitingForDebuggerState m_waitingForDebuggerState;

};