content/common/service_worker/embedded_worker_messages.h - Issue 1675613002: service worker: use 200 OK for update requests even in the no update case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/embedded_worker_messages.h

Issue 1675613002: service worker: use 200 OK for update requests even in the no update case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asan and fix win compile? Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc ('k') | content/renderer/service_worker/embedded_worker_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/embedded_worker_messages.h

diff --git a/content/common/service_worker/embedded_worker_messages.h b/content/common/service_worker/embedded_worker_messages.h

index fc9f02ea343bf08a895e3916f427ed935115925d..1cad10412667f15298fd8b8142f421a7a0bc3523 100644

--- a/content/common/service_worker/embedded_worker_messages.h

+++ b/content/common/service_worker/embedded_worker_messages.h

@@ -26,6 +26,7 @@ IPC_STRUCT_BEGIN(EmbeddedWorkerMsg_StartWorker_Params)

IPC_STRUCT_MEMBER(GURL, scope)

IPC_STRUCT_MEMBER(GURL, script_url)

IPC_STRUCT_MEMBER(int, worker_devtools_agent_route_id)

+ IPC_STRUCT_MEMBER(bool, pause_after_download)

IPC_STRUCT_MEMBER(bool, wait_for_debugger)

IPC_STRUCT_MEMBER(content::V8CacheOptions, v8_cache_options)

IPC_STRUCT_END()

@@ -45,6 +46,11 @@ IPC_STRUCT_END()

IPC_MESSAGE_CONTROL1(EmbeddedWorkerMsg_StartWorker,

EmbeddedWorkerMsg_StartWorker_Params /* params */)

+// Browser -> Renderer message to resume a worker that has been started

+// with the pause_after_download option.

+IPC_MESSAGE_CONTROL1(EmbeddedWorkerMsg_ResumeAfterDownload,

+ int /* embedded_worker_id */)

// Browser -> Renderer message to stop (terminate) the embedded worker.

IPC_MESSAGE_CONTROL1(EmbeddedWorkerMsg_StopWorker,

int /* embedded_worker_id */)