content/browser/service_worker/service_worker_version_unittest.cc - Issue 1675613002: service worker: use 200 OK for update requests even in the no update case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 1675613002: service worker: use 200 OK for update requests even in the no update case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asan and fix win compile? Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | content/browser/service_worker/service_worker_write_to_cache_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version_unittest.cc

diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc

index 3247312aeae996a5a17fcef011e35e2f891753e6..351a32e5036610e14cec26a74b6bbc78880cd605 100644

--- a/content/browser/service_worker/service_worker_version_unittest.cc

+++ b/content/browser/service_worker/service_worker_version_unittest.cc

@@ -290,7 +290,8 @@ class MessageReceiverDisallowStart : public MessageReceiver {

void OnStartWorker(int embedded_worker_id,

int64_t service_worker_version_id,

const GURL& scope,

- const GURL& script_url) override {

+ const GURL& script_url,

+ bool pause_after_download) override {

switch (mode_) {

case StartMode::STALL:

break; // Do nothing.

@@ -298,8 +299,9 @@ class MessageReceiverDisallowStart : public MessageReceiver {

OnStopWorker(embedded_worker_id);

break;

case StartMode::SUCCEED:

- MessageReceiver::OnStartWorker(

- embedded_worker_id, service_worker_version_id, scope, script_url);

+ MessageReceiver::OnStartWorker(embedded_worker_id,

+ service_worker_version_id, scope,

+ script_url, pause_after_download);

break;

}