content/browser/service_worker/embedded_worker_test_helper.h - Issue 1675613002: service worker: use 200 OK for update requests even in the no update case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.h

Issue 1675613002: service worker: use 200 OK for update requests even in the no update case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asan and fix win compile? Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance_unittest.cc ('k') | content/browser/service_worker/embedded_worker_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_test_helper.h

diff --git a/content/browser/service_worker/embedded_worker_test_helper.h b/content/browser/service_worker/embedded_worker_test_helper.h

index 81373776d6bbefcbdf4a3b7b645355bd008ce325..40de8b3c73eea105dfc27b48091751b785c6a923 100644

--- a/content/browser/service_worker/embedded_worker_test_helper.h

+++ b/content/browser/service_worker/embedded_worker_test_helper.h

@@ -105,7 +105,9 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,

virtual void OnStartWorker(int embedded_worker_id,

int64_t service_worker_version_id,

const GURL& scope,

- const GURL& script_url);

+ const GURL& script_url,

+ bool pause_after_download);

+ virtual void OnResumeAfterDownload(int embedded_worker_id);

virtual void OnStopWorker(int embedded_worker_id);

virtual bool OnMessageToWorker(int thread_id,

int embedded_worker_id,

@@ -145,6 +147,7 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,

class MockEmbeddedWorkerSetup;

void OnStartWorkerStub(const EmbeddedWorkerMsg_StartWorker_Params& params);

+ void OnResumeAfterDownloadStub(int embedded_worker_id);

void OnStopWorkerStub(int embedded_worker_id);

void OnMessageToWorkerStub(int thread_id,

int embedded_worker_id,