service worker: use 200 OK for update requests even in the no update case

content/browser/service_worker/embedded_worker_instance.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_EMBEDDED_WORKER_INSTANCE_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_EMBEDDED_WORKER_INSTANCE_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 82 matching lines @@
     virtual void OnReportException(const base::string16& error_message,
                                    int line_number,
                                    int column_number,
                                    const GURL& source_url) {}
     virtual void OnReportConsoleMessage(int source_identifier,
                                         int message_level,
                                         const base::string16& message,
                                         int line_number,
                                         const GURL& source_url) {}
     // Returns false if the message is not handled by this listener.
-    virtual bool OnMessageReceived(const IPC::Message& message) = 0;
+    virtual bool OnMessageReceived(const IPC::Message& message);
   };
 
   ~EmbeddedWorkerInstance();
 
   // Starts the worker. It is invalid to call this when the worker is not in
   // STOPPED status. |callback| is invoked after the worker script has been
-  // started and evaluated, or when an error occurs.
+  // started and evaluated, or when an error occurs. If |pause_after_download|
+  // is true, the worker pauses after loading until ResumeAfterDownload() is
+  // called.
   void Start(int64_t service_worker_version_id,
              const GURL& scope,
              const GURL& script_url,
-             const StatusCallback& callback);
+             const StatusCallback& callback,
+             bool pause_after_download = false);

[michaeln, 2016/02/06 01:13:58]

i think our style guide prohibits default param values, has that changed?

[falken, 2016/02/10 05:40:40]

AFAICT yes: https://google.github.io/styleguide/cppguide.html#Default_Arguments

 
   // Stops the worker. It is invalid to call this when the worker is
   // not in STARTING or RUNNING status.
   // This returns false if stopping a worker fails immediately, e.g. when
   // IPC couldn't be sent to the worker.
   ServiceWorkerStatusCode Stop();
 
   // Stops the worker if the worker is not being debugged (i.e. devtools is
   // not attached). This method is called by a stop-worker timer to kill
   // idle workers.
   void StopIfIdle();
 
   // Sends |message| to the embedded worker running in the child process.
   // It is invalid to call this while the worker is not in STARTING or RUNNING
   // status.
   ServiceWorkerStatusCode SendMessage(const IPC::Message& message);
 
+  // Resumes the worker if it paused after download.
+  void ResumeAfterDownload();
+
   // Returns the ServiceRegistry for this worker. It is invalid to call this
   // when the worker is not in STARTING or RUNNING status.
   ServiceRegistry* GetServiceRegistry();
 
   int embedded_worker_id() const { return embedded_worker_id_; }
   Status status() const { return status_; }
   StartingPhase starting_phase() const {
     DCHECK_EQ(STARTING, status());
     return starting_phase_;
   }
@@ skipping 142 matching lines @@
   base::TimeTicks start_timing_;
 
   base::WeakPtrFactory<EmbeddedWorkerInstance> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(EmbeddedWorkerInstance);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_EMBEDDED_WORKER_INSTANCE_H_