mojo/edk/embedder/embedder.cc - Issue 1675603002: [mojo-edk] Simplify multiprocess pipe bootstrap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/embedder/embedder.cc

Issue 1675603002: [mojo-edk] Simplify multiprocess pipe bootstrap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/edk/embedder/embedder.cc

diff --git a/mojo/edk/embedder/embedder.cc b/mojo/edk/embedder/embedder.cc

index d1ab6c69d692be9f640bfb2df356fad29aa6531e..b290c9b72e018f1040300562fff7b8646bf12f13 100644

--- a/mojo/edk/embedder/embedder.cc

+++ b/mojo/edk/embedder/embedder.cc

@@ -107,8 +107,8 @@ void ShutdownIPCSupport() {

ScopedMessagePipeHandle CreateMessagePipe(

ScopedPlatformHandle platform_handle) {

- NOTREACHED();

- return ScopedMessagePipeHandle();

+ DCHECK(internal::g_core);

+ return internal::g_core->CreateMessagePipe(std::move(platform_handle));

}

void CreateMessagePipe(