[mojo-edk] Simplify multiprocess pipe bootstrap

mojo/shell/runner/host/child_process.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/shell/runner/host/child_process.h"
 
 #include <stdint.h>
 
 #include <utility>
 
@@ skipping 33 matching lines @@
 #include "base/rand_util.h"
 #include "base/sys_info.h"
 #include "mojo/shell/runner/host/linux_sandbox.h"
 #endif
 
 namespace mojo {
 namespace shell {
 
 namespace {
 
-void DidCreateChannel(embedder::ChannelInfo* channel_info) {
-  DVLOG(2) << "ChildControllerImpl::DidCreateChannel()";
-}
-
 // Blocker ---------------------------------------------------------------------
 
 // Blocks a thread until another thread unblocks it, at which point it unblocks
 // and runs a closure provided by that thread.
 class Blocker {
  public:
   class Unblocker {
    public:
     explicit Unblocker(Blocker* blocker = nullptr) : blocker_(blocker) {}
     ~Unblocker() {}
@@ skipping 225 matching lines @@
   scoped_ptr<mojo::shell::LinuxSandbox> sandbox(
       new mojo::shell::LinuxSandbox(permissions));
   sandbox->Warmup();
   sandbox->EngageNamespaceSandbox();
   sandbox->EngageSeccompSandbox();
   sandbox->Seal();
   return sandbox;
 }
 #endif
 
-void InitializeHostMessagePipe(
-    embedder::ScopedPlatformHandle platform_channel,
-    scoped_refptr<base::TaskRunner> io_task_runner,
-    const base::Callback<void(ScopedMessagePipeHandle)>& callback) {
-  if (base::CommandLine::ForCurrentProcess()->HasSwitch("use-new-edk")) {
-    embedder::SetParentPipeHandle(std::move(platform_channel));
-    std::string primordial_pipe_token =
-        base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
-            switches::kPrimordialPipeToken);
-    edk::CreateChildMessagePipe(primordial_pipe_token, callback);
-  } else {
-    ScopedMessagePipeHandle host_message_pipe;
-    host_message_pipe =
-        embedder::CreateChannel(std::move(platform_channel),
-                                base::Bind(&DidCreateChannel), io_task_runner);
-    callback.Run(std::move(host_message_pipe));
-  }
-}
-
-void OnHostMessagePipeCreated(AppContext* app_context,
-                              base::NativeLibrary app_library,
-                              const Blocker::Unblocker& unblocker,
-                              ScopedMessagePipeHandle pipe) {
-  app_context->controller_runner()->PostTask(
-      FROM_HERE,
-      base::Bind(&ChildControllerImpl::Init, base::Unretained(app_context),
-                 base::Unretained(app_library), base::Passed(&pipe),
-                 unblocker));
+ScopedMessagePipeHandle InitializeHostMessagePipe(
+    edk::ScopedPlatformHandle platform_channel,
+    scoped_refptr<base::TaskRunner> io_task_runner) {
+  edk::SetParentPipeHandle(std::move(platform_channel));
+  std::string primordial_pipe_token =
+      base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+          switches::kPrimordialPipeToken);
+  return edk::CreateChildMessagePipe(primordial_pipe_token);
 }
 
 }  // namespace
 
 int ChildProcessMain() {
   DVLOG(2) << "ChildProcessMain()";
   const base::CommandLine& command_line =
       *base::CommandLine::ForCurrentProcess();
 
 #if defined(OS_LINUX) && !defined(OS_ANDROID)
@@ skipping 12 matching lines @@
 #if !defined(OFFICIAL_BUILD)
   // Initialize stack dumping just before initializing sandbox to make
   // sure symbol names in all loaded libraries will be cached.
   base::debug::EnableInProcessStackDumping();
 #endif
 #if defined(OS_LINUX) && !defined(OS_ANDROID)
   if (command_line.HasSwitch(switches::kEnableSandbox))
     sandbox = InitializeSandbox();
 #endif
 
-  embedder::ScopedPlatformHandle platform_channel =
-      embedder::PlatformChannelPair::PassClientHandleFromParentProcess(
+  edk::ScopedPlatformHandle platform_channel =
+      edk::PlatformChannelPair::PassClientHandleFromParentProcess(
           command_line);
   CHECK(platform_channel.is_valid());
 
   DCHECK(!base::MessageLoop::current());
 
   Blocker blocker;
   AppContext app_context;
   app_context.Init();
   app_context.StartControllerThread();
 
+  ScopedMessagePipeHandle host_pipe = InitializeHostMessagePipe(
+      std::move(platform_channel), app_context.io_runner());
   app_context.controller_runner()->PostTask(
       FROM_HERE,
-      base::Bind(
-          &InitializeHostMessagePipe, base::Passed(&platform_channel),
-          make_scoped_refptr(app_context.io_runner()),
-          base::Bind(&OnHostMessagePipeCreated, base::Unretained(&app_context),
-                     base::Unretained(app_library), blocker.GetUnblocker())));
+      base::Bind(&ChildControllerImpl::Init, &app_context, app_library,
+                 base::Passed(&host_pipe), blocker.GetUnblocker()));
 
   // This will block, then run whatever the controller wants.
   blocker.Block();
 
   app_context.Shutdown();
 
   return 0;
 }
 
 }  // namespace shell
 }  // namespace mojo