Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: src/address-map.cc

Issue 1675553002: [serializer] Ensure immortal immovable roots are deserialized correctly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/snapshot/serialize.cc » ('j') | src/snapshot/serialize.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/address-map.cc
diff --git a/src/address-map.cc b/src/address-map.cc
index 681661af2978bbdcc78754a2f9e5a82e1dc9f46d..c154a9e54827813a815a312b654c7fb8645662b6 100644
--- a/src/address-map.cc
+++ b/src/address-map.cc
@@ -29,6 +29,11 @@ RootIndexMap::RootIndexMap(Isolate* isolate) {
} else {
SetValue(LookupEntry(map_, heap_object, true), i);
}
+ } else {
+ // Immortal immovable root objects are constant and allocated on the first
+ // page of old space. Non-constant roots cannot be immortal immovable.
+ // The root index map contains all immortal immmovable root objects.
+ CHECK(!Heap::RootIsImmortalImmovable(root_index));
Michael Starzinger 2016/02/05 14:47:59 I am not sure about this check. It only holds beca
}
}
isolate->set_root_index_map(map_);
« no previous file with comments | « no previous file | src/snapshot/serialize.cc » ('j') | src/snapshot/serialize.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698