Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: tools/battor_agent/battor_agent.cc

Issue 1675503002: tools/battor_agent: Increases the time given for BattOr reset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improves comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/battor_agent/battor_agent.cc
diff --git a/tools/battor_agent/battor_agent.cc b/tools/battor_agent/battor_agent.cc
index b36192ac84b5abba6e80dd5d3e98b2765f2e7506..4c06fbcc4d716fa4e416229b57fb36b6a24f75e2 100644
--- a/tools/battor_agent/battor_agent.cc
+++ b/tools/battor_agent/battor_agent.cc
@@ -170,6 +170,11 @@ void BattOrAgent::OnBytesSent(bool success) {
switch (last_action_) {
case Action::SEND_RESET:
+ // TODO(charliea): Ideally, we'd just like to send an init, and the BattOr
+ // firmware can handle whether a reset is necessary or not, sending an
+ // init ack regardless. This reset can be removed once this is true.
+ // https://github.com/aschulm/battor/issues/30 tracks this.
+
// Wait for the reset to happen before sending the init message.
PerformDelayedAction(Action::SEND_INIT, base::TimeDelta::FromSeconds(
kBattOrResetTimeSeconds));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698