Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: ui/views/view_unittest.cc

Issue 1675483002: Allow use of container cbegin() and cend() methods, plus sample uses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add note about non-member cbegin() and cend(). Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « styleguide/c++/c++11.html ('k') | ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/view_unittest.cc
diff --git a/ui/views/view_unittest.cc b/ui/views/view_unittest.cc
index 68675c0aa8d0748f74102ea9f7b7e3295d9d9334..2ff4faa564459c4ad85e1b8d9dbdb93d8a1df6aa 100644
--- a/ui/views/view_unittest.cc
+++ b/ui/views/view_unittest.cc
@@ -3431,12 +3431,8 @@ TEST_F(ViewTest, GetViewByID) {
View::Views views;
v1.GetViewsInGroup(kGroup, &views);
EXPECT_EQ(2U, views.size());
-
- View::Views::const_iterator i(std::find(views.begin(), views.end(), &v3));
- EXPECT_NE(views.end(), i);
-
- i = std::find(views.begin(), views.end(), &v4);
- EXPECT_NE(views.end(), i);
+ EXPECT_NE(views.cend(), std::find(views.cbegin(), views.cend(), &v3));
+ EXPECT_NE(views.cend(), std::find(views.cbegin(), views.cend(), &v4));
}
TEST_F(ViewTest, AddExistingChild) {
« no previous file with comments | « styleguide/c++/c++11.html ('k') | ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698