Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1675433003: [turbofan] Reducers should revisit end after merging to it. (Closed)

Created:
4 years, 10 months ago by Jarin
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reducers should revisit end after merging to it. Committed: https://crrev.com/52f2dbcac1a1954b59a4c601c1f71e27e769a9c8 Cr-Commit-Position: refs/heads/master@{#33767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M src/compiler/js-call-reducer.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/compiler/regress-dead-throw-inlining.js View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 10 months ago (2016-02-05 10:40:23 UTC) #2
Benedikt Meurer
lgtm
4 years, 10 months ago (2016-02-05 10:44:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675433003/1
4 years, 10 months ago (2016-02-05 10:44:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 11:01:21 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 11:01:54 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/52f2dbcac1a1954b59a4c601c1f71e27e769a9c8
Cr-Commit-Position: refs/heads/master@{#33767}

Powered by Google App Engine
This is Rietveld 408576698