Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1675363002: Revert of Chromoting iOS src directories should be ignored by the chromium checkout. (Closed)

Created:
4 years, 10 months ago by sdefresne
Modified:
4 years, 10 months ago
Reviewers:
Sergey Ulanov, nicholss
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Chromoting iOS src directories should be ignored by the chromium checkout. (patchset #1 id:1 of https://codereview.chromium.org/1669943002/ ) Reason for revert: This is breaking dowsntream iOS tree as it prevent the bots to add any new file in ios_internal. Original issue's description: > Add remoting iOS dirs to .gitignore. > > Committed: https://crrev.com/27ee0707363b9ec52202a1c394f7cacf866a9cfe > Cr-Commit-Position: refs/heads/master@{#373850} TBR=sergeyu@chromium.org,nicholss@chromium.org NOTRY=true Committed: https://crrev.com/4498f5073246b36587430e05329e89f477f28485 Cr-Commit-Position: refs/heads/master@{#374148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M .gitignore View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sdefresne
Created Revert of Chromoting iOS src directories should be ignored by the chromium checkout.
4 years, 10 months ago (2016-02-08 18:35:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675363002/1
4 years, 10 months ago (2016-02-08 18:39:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 18:47:52 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 18:50:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4498f5073246b36587430e05329e89f477f28485
Cr-Commit-Position: refs/heads/master@{#374148}

Powered by Google App Engine
This is Rietveld 408576698