DescriptionRevert 251397 "[WebsiteSettings] Fix bug in permission bubble ma..."
Revert reason: cros unit test failures
See: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29
Sample output:
ersiveModeControllerAshTest.TabAndBrowserFullscreen (run #3):
[ RUN ] ImmersiveModeControllerAshTest.TabAndBrowserFullscreen
Xlib: extension "RANDR" missing on display ":9".
[21038:21038:0214/121606:1047752665:WARNING:native_view_host_aura.cc(71)] NativeViewHostAura::InstallClip is not implemented yet.
[21038:21038:0214/121606:1047752835:WARNING:native_view_host_aura.cc(71)] NativeViewHostAura::InstallClip is not implemented yet.
[21038:21038:0214/121606:1047752914:WARNING:native_view_host_aura.cc(71)] NativeViewHostAura::InstallClip is not implemented yet.
Received signal 11 SEGV_MAPERR 00020000002d
[0x7f0b3aa767ce] base::debug::StackTrace::StackTrace()
[0x7f0b3aa76cf8] base::debug::(anonymous namespace)::StackDumpSignalHandler()
[0x7f0b34340cb0] \u003Cunknown>
[0x00000379579c] PermissionBubbleViewViews::~PermissionBubbleViewViews()
[0x00000373aafb] BrowserView::~BrowserView()
[0x00000373ad69] BrowserView::~BrowserView()
[0x7f0b38da5de2] views::View::~View()
[0x7f0b38dbbcf0] views::NonClientView::~NonClientView()
[0x7f0b38dbbd69] views::NonClientView::~NonClientView()
[0x7f0b38da5bed] views::View::DoRemoveChildView()
[0x7f0b38da5ce5] views::View::RemoveAllChildViews()
[0x7f0b38da9dd8] views::internal::RootView::~RootView()
[0x000003734aa0] BrowserRootView::~BrowserRootView()
> [WebsiteSettings] Fix bug in permission bubble manager to alter showing state when bubble is closed.
>
> This bug meant that subsequent calls to AddRequest wouldn't show the bubble, since the manager still believed it was being shown.
>
> R=leng@chromium.org
>
> Review URL: https://codereview.chromium.org/162423002
TBR=gbillock@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251414
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|