Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 167533002: Exclude bookmark import strings for Android. (Closed)

Created:
6 years, 10 months ago by aurimas (slooooooooow)
Modified:
6 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Visibility:
Public.

Description

Exclude bookmark import strings for Android. Android has a custom UI and code for handing bookmark import. BUG=326023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252286

Patch Set 1 #

Patch Set 2 : Fixed build issue #

Patch Set 3 : Remove strings removed in https://chromiumcodereview.appspot.com/14322002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -117 lines) Patch
M chrome/app/bookmarks_strings.grdp View 1 chunk +25 lines, -23 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +83 lines, -90 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
aurimas (slooooooooow)
Hey Ted, Please take a look at this CL. Thanks, Aurimas
6 years, 10 months ago (2014-02-14 23:06:41 UTC) #1
Ted C
On 2014/02/14 23:06:41, aurimas wrote: > Hey Ted, > > Please take a look at ...
6 years, 10 months ago (2014-02-14 23:12:45 UTC) #2
aurimas (slooooooooow)
On 2014/02/14 23:12:45, Ted C wrote: > On 2014/02/14 23:06:41, aurimas wrote: > > Hey ...
6 years, 10 months ago (2014-02-18 18:52:52 UTC) #3
Ted C
lgtm
6 years, 10 months ago (2014-02-18 18:56:24 UTC) #4
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-18 18:58:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/167533002/90001
6 years, 10 months ago (2014-02-18 18:59:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 19:14:33 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=50740
6 years, 10 months ago (2014-02-18 19:14:34 UTC) #8
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-20 02:05:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/167533002/280001
6 years, 10 months ago (2014-02-20 02:30:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/167533002/280001
6 years, 10 months ago (2014-02-20 05:19:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/167533002/280001
6 years, 10 months ago (2014-02-20 09:20:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/167533002/280001
6 years, 10 months ago (2014-02-20 12:35:57 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 17:17:41 UTC) #14
Message was sent while issue was closed. 
Change committed as 252286

Powered by Google App Engine
This is Rietveld 408576698