Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 167523003: ARM: build fix for r19380. (Closed)

Created:
6 years, 10 months ago by palfia
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: build fix for r19380. This commit fixes the debug build on Linux with gcc 4.6.3 and 4.7.2. Port r19381 (5476e11b) BUG= R=dcarney@chromium.org, plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=19398

Patch Set 1 #

Patch Set 2 : A64 port. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/a64/code-stubs-a64.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
palfia
PTAL.
6 years, 10 months ago (2014-02-14 21:21:59 UTC) #1
Paul Lind
LGTM, but we need other review. Since you've nicely ported this to ARM do you ...
6 years, 10 months ago (2014-02-14 21:37:53 UTC) #2
palfia
I've uploaded the A64 port and updated the CL description.
6 years, 10 months ago (2014-02-14 22:03:02 UTC) #3
dcarney
lgtm
6 years, 10 months ago (2014-02-17 07:33:34 UTC) #4
Jakob Kummerow
Committed patchset #2 manually as r19398 (presubmit successful).
6 years, 10 months ago (2014-02-17 08:10:09 UTC) #5
Jakob Kummerow
6 years, 10 months ago (2014-02-17 08:10:49 UTC) #6
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698