src/debug/debug-evaluate.cc - Issue 1675223002: Mark maps having a hidden prototype rather than maps of hidden prototypes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-evaluate.cc

Issue 1675223002: Mark maps having a hidden prototype rather than maps of hidden prototypes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/debug-evaluate.cc

diff --git a/src/debug/debug-evaluate.cc b/src/debug/debug-evaluate.cc

index e19b93eebea0174e85ae44adb4e2c011589b6405..c76112baffa0a491cbba67c1ccc556d5ef8e2cfe 100644

--- a/src/debug/debug-evaluate.cc

+++ b/src/debug/debug-evaluate.cc

@@ -111,7 +111,7 @@ MaybeHandle<Object> DebugEvaluate::Evaluate(

// Skip the global proxy as it has no properties and always delegates to the

// real global object.

if (result->IsJSGlobalProxy()) {

- PrototypeIterator iter(isolate, result);

+ PrototypeIterator iter(isolate, Handle<JSGlobalProxy>::cast(result));

// TODO(verwaest): This will crash when the global proxy is detached.

result = PrototypeIterator::GetCurrent<JSObject>(iter);

}

« no previous file with comments | « src/builtins.cc ('k') | src/factory.cc » ('j') | no next file with comments »