Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: src/arm/builtins-arm.cc

Issue 1675223002: Mark maps having a hidden prototype rather than maps of hidden prototypes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api-natives.cc ('k') | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 1447 matching lines...) Expand 10 before | Expand all | Expand 10 after
1458 __ CompareObjectType(type, ip, ip, FUNCTION_TEMPLATE_INFO_TYPE); 1458 __ CompareObjectType(type, ip, ip, FUNCTION_TEMPLATE_INFO_TYPE);
1459 1459
1460 // Otherwise load the parent function template and iterate. 1460 // Otherwise load the parent function template and iterate.
1461 __ ldr(type, 1461 __ ldr(type,
1462 FieldMemOperand(type, FunctionTemplateInfo::kParentTemplateOffset), 1462 FieldMemOperand(type, FunctionTemplateInfo::kParentTemplateOffset),
1463 eq); 1463 eq);
1464 __ b(&function_template_loop, eq); 1464 __ b(&function_template_loop, eq);
1465 1465
1466 // Load the next prototype. 1466 // Load the next prototype.
1467 __ bind(&next_prototype); 1467 __ bind(&next_prototype);
1468 __ ldr(ip, FieldMemOperand(map, Map::kBitField3Offset));
1469 __ tst(ip, Operand(Map::HasHiddenPrototype::kMask));
1470 __ b(eq, receiver_check_failed);
1468 __ ldr(receiver, FieldMemOperand(map, Map::kPrototypeOffset)); 1471 __ ldr(receiver, FieldMemOperand(map, Map::kPrototypeOffset));
1469 // End if the prototype is null or not hidden.
1470 __ CompareRoot(receiver, Heap::kNullValueRootIndex);
1471 __ b(eq, receiver_check_failed);
1472 __ ldr(map, FieldMemOperand(receiver, HeapObject::kMapOffset)); 1472 __ ldr(map, FieldMemOperand(receiver, HeapObject::kMapOffset));
1473 __ ldr(ip, FieldMemOperand(map, Map::kBitField3Offset));
1474 __ tst(ip, Operand(Map::IsHiddenPrototype::kMask));
1475 __ b(eq, receiver_check_failed);
1476 // Iterate. 1473 // Iterate.
1477 __ b(&prototype_loop_start); 1474 __ b(&prototype_loop_start);
1478 1475
1479 __ bind(&receiver_check_passed); 1476 __ bind(&receiver_check_passed);
1480 } 1477 }
1481 1478
1482 1479
1483 void Builtins::Generate_HandleFastApiCall(MacroAssembler* masm) { 1480 void Builtins::Generate_HandleFastApiCall(MacroAssembler* masm) {
1484 // ----------- S t a t e ------------- 1481 // ----------- S t a t e -------------
1485 // -- r0 : number of arguments excluding receiver 1482 // -- r0 : number of arguments excluding receiver
(...skipping 1200 matching lines...) Expand 10 before | Expand all | Expand 10 after
2686 } 2683 }
2687 } 2684 }
2688 2685
2689 2686
2690 #undef __ 2687 #undef __
2691 2688
2692 } // namespace internal 2689 } // namespace internal
2693 } // namespace v8 2690 } // namespace v8
2694 2691
2695 #endif // V8_TARGET_ARCH_ARM 2692 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/api-natives.cc ('k') | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698