Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1675223002: Mark maps having a hidden prototype rather than maps of hidden prototypes. (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni, Yang
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark maps having a hidden prototype rather than maps of hidden prototypes. Generally we only care whether the next object is a hidden prototype. It's simpler to check whether the current object has a hidden prototype instead of walking to the next prototype and checking its map. BUG= Committed: https://crrev.com/d2503c4dbd50c666fe34536f7e7a3e8541640b1c Cr-Commit-Position: refs/heads/master@{#33816}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -214 lines) Patch
M src/api-natives.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/builtins.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/ic/call-optimization.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/lookup.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/objects.h View 5 chunks +12 lines, -14 lines 0 comments Download
M src/objects.cc View 12 chunks +43 lines, -24 lines 0 comments Download
M src/objects-inl.h View 2 chunks +9 lines, -11 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M src/prototype.h View 5 chunks +44 lines, -62 lines 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-object.cc View 5 chunks +13 lines, -11 lines 0 comments Download
M src/string-stream.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675223002/1
4 years, 10 months ago (2016-02-08 11:58:27 UTC) #2
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-08 12:05:03 UTC) #4
Yang
On 2016/02/08 12:05:03, Toon Verwaest wrote: > ptal debug lgtm.
4 years, 10 months ago (2016-02-08 12:23:27 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 12:28:49 UTC) #7
Camillo Bruni
lgtm with one comment on x87 https://codereview.chromium.org/1675223002/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1675223002/diff/1/src/builtins.cc#newcode2082 src/builtins.cc:2082: Handle<JSReceiver> receiver = ...
4 years, 10 months ago (2016-02-08 13:24:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675223002/20001
4 years, 10 months ago (2016-02-08 13:28:48 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-08 13:49:54 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 13:50:30 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d2503c4dbd50c666fe34536f7e7a3e8541640b1c
Cr-Commit-Position: refs/heads/master@{#33816}

Powered by Google App Engine
This is Rietveld 408576698